Skip to content

Improved Compatibility Around LAST_INSERT_ID#17408

Merged
systay merged 43 commits intovitessio:mainfrom
planetscale:last-insert-id-step1
Dec 20, 2024
Merged

Improved Compatibility Around LAST_INSERT_ID#17408
systay merged 43 commits intovitessio:mainfrom
planetscale:last-insert-id-step1

Conversation

@systay
Copy link
Copy Markdown
Collaborator

@systay systay commented Dec 19, 2024

Description

This PR improves last_insert_id(x) behavior to align more closely with MySQL in various scenarios.

Key changes

  1. New fetch_last_insert_id Field
    Introduced a boolean field, fetch_last_insert_id, in the ExecuteOptions proto.
    • When enabled, vttablet automatically runs a SELECT last_insert_id() query immediately after executing a query containing a last_insert_id(x) expression.
    • The planner automatically sets this flag upon detecting such expressions.
    • This is to work around a mysql bug.
  2. sqltypes.Result Updates
    • Added a new field, InsertIDChanged.
    • This field signals that the session state must be updated with the new InsertID, even if the value is 0
  3. Query Signature Enhancements:
    • Updated semantic checking to store relevant information in the query’s QuerySignature.
  4. Improved LIMIT Behavior:
    • Enhanced LIMIT to ensure all input rows are received when expecting last_insert_id values.
    • As a result, in some scenarios, data retrieval from tablets cannot be stopped until all results are fetched.

More changes around this are coming.

Related Issue(s)

Fixes #17298

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

systay and others added 19 commits December 19, 2024 07:06
@systay
proto: add fetch_last_insert_id to ExecuteOptions
9a3ee9b 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
test: clean up test
55cddc6 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
feat: fetch last_insert_id when asked for it
d7df55f 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
feat: update the ExecuteMultiShard interface method
b2236a6 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
feat: add semantic query signature for last_insert_id with arguments
fcc3619 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
feat: pass on the FetchLastInsertID to the engine primitives
d82f3fb 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
bugfix: check if options exist before using
02309c9 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal @systay
added insertID changed boolean to indicate if last_insert id value is…
6037a4a 
… modified

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay
feat: pass down FetchLastInsertID bool
fa23fd1 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
feat: handle last_insert_id with arguments in more situations
d92546f 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
feat: pass it along for streaming queries
56624f6 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
test: add transactions into the test mix
e0bb055 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal @systay
result append: remove the short circuit code
598e21f 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay
feat: make sure to check last insert id in transactions, and don't fi…
a5145d6 
…nish early when limiting row count

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
feat: stop receiving data from tablet when we know we don't need it
aea2c38 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
test: add plan-test showing when we need to exhaust the input stream
5b8ed47 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
bugfix: protect against nil exceptions
9fdbc25 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
test: add errors to test log
193e007 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
feat: abort early once we reach count = 0
6db0700 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Dec 19, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

harshit-gangal
harshit-gangal reviewed Dec 20, 2024
View reviewed changes
harshit-gangal
harshit-gangal reviewed Dec 20, 2024
View reviewed changes
@systay
refactor: simplify coersion logic
959aee9 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
Merge remote-tracking branch 'upstream/main' into last-insert-id-step1
4798918 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
test: make e2e plan-tests run DML cases
4565dca 
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
harshit-gangal reviewed Dec 20, 2024
View reviewed changes
harshit-gangal
harshit-gangal reviewed Dec 20, 2024
View reviewed changes
harshit-gangal
harshit-gangal reviewed Dec 20, 2024
View reviewed changes
@systay
simplify logic
b2c1f9c 
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
harshit-gangal reviewed Dec 20, 2024
View reviewed changes
harshit-gangal
harshit-gangal reviewed Dec 20, 2024
View reviewed changes
harshit-gangal
harshit-gangal reviewed Dec 20, 2024
View reviewed changes
harshit-gangal
harshit-gangal reviewed Dec 20, 2024
View reviewed changes
harshit-gangal
harshit-gangal reviewed Dec 20, 2024
View reviewed changes
harshit-gangal
harshit-gangal reviewed Dec 20, 2024
View reviewed changes
@systay
check that we have a result before using it
66bc6eb 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
fix executor and improve tests for scatter_con
aebd8e4 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
compare with length and not nil
eb58df1 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 77.93594% with 62 lines in your changes missing coverage. Please review.

Project coverage is 67.64%. Comparing base (9714713) to head (eb58df1).

Files with missing lines Patch % Lines
go/vt/vttablet/tabletserver/query_executor.go 49.39% 42 Missing ⚠️
go/vt/vtgate/executorcontext/vcursor_impl.go 62.50% 9 Missing ⚠️
go/vt/vtgate/engine/plan_description.go 0.00% 4 Missing ⚠️
go/vt/vtgate/engine/insert.go 60.00% 2 Missing ⚠️
go/vt/vtgate/scatter_conn.go 85.71% 2 Missing ⚠️
go/vt/vtgate/engine/lock.go 0.00% 1 Missing ⚠️
go/vt/vtgate/engine/unlock.go 0.00% 1 Missing ⚠️
go/vt/vtgate/engine/vexplain.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #17408    +/-   ##
========================================
  Coverage   67.63%   67.64%            
========================================
  Files        1581     1581            
  Lines      253860   254002   +142     
========================================
+ Hits       171708   171809   +101     
- Misses      82152    82193    +41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

harshit-gangal
harshit-gangal reviewed Dec 20, 2024
View reviewed changes
harshit-gangal
harshit-gangal reviewed Dec 20, 2024
View reviewed changes
harshit-gangal
harshit-gangal reviewed Dec 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left few comments

@systay
simplify logic
1c2be73 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
test: refactor test
b14f0e8 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit e750d22 into vitessio:main Dec 20, 2024
@systay systay deleted the last-insert-id-step1 branch December 20, 2024 15:22
@BrewTestBot BrewTestBot mentioned this pull request Apr 29, 2025
Merged
@nickvanw nickvanw mentioned this pull request Nov 25, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

@vmg vmg Awaiting requested review from vmg

+1 more reviewer

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Milestone

v22.0.0

Development

Successfully merging this pull request may close these issues.

Bug Report: result mismatch on LAST_INSERT_ID() between Vitess and MySQL

3 participants

@systay @harshit-gangal @GuptaManan100